-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WG-260 add map control bar #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested maps and LGTM.
Not critical but should the MapControlBar have a larger font like prod?
Follow on:
I'm seeing an issue for a public map where the Add Asset from DesignSafe button is appearing when it should not. See here Not a bug from your code, but the handling of if the AssetButton should show or not is faulty.
Simpilfy MapProject
Spacing and ellipses were broken with upstream changes; unclear if my previous styles were incorrect or imcompatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fixed in separate PR. |
Overview:
This PR introduces a control bar at the top of the map to align with the behavior of the Angular Hazmapper app:
It also handles different errors that could occur.
Additional Hooks:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
Example routes are provided that correspond to maps on staging (i.e.
GeoapiBackendEnvironment.Staging
insrc/secret_local.ts
)This map project does not exist
; right now real uuids have to be used but fixing in hotfix: return 404 if project uuid is invalid geoapi#236nathan_f
UI Photos:
Error getting map:
Map doesn't exist
Map is private and user isn't a member of the project:
Public map (not logged in)
Public map (logged in)
Private map view
Notes: